Regard endianness independent of a specific CPU type or OS#155
Open
68420948 wants to merge 1 commit intotrendmicro:masterfrom
Open
Regard endianness independent of a specific CPU type or OS#15568420948 wants to merge 1 commit intotrendmicro:masterfrom
68420948 wants to merge 1 commit intotrendmicro:masterfrom
Conversation
Regard endianess based on __BYTE_ORDER__ instead of __SPARC or _AIX. This makes sure endianness is handled correctly, at least with using GCC, without the need to fake a CPU type like proposed in trendmicro#131. Picking endianness based on a specific OS seems not correct at all.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regard endianess based on BYTE_ORDER instead of __SPARC or _AIX.
This makes sure endianness is handled correctly, at least with using GCC, without the need to fake a CPU type like proposed in #131.
Picking endianness based on a specific OS seems not correct at all.